Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No version needed in docker-compose.yml and updates to reflect latest changes in the docker ecosystem #149

Open
tippexs opened this issue Nov 7, 2023 · 1 comment

Comments

@tippexs
Copy link

tippexs commented Nov 7, 2023

Thanks for the awesome description and work on the Dockerfiles / Docker compose files! Really appreciated it!

As Docker Captain I am always looking at the Docker parts of a project and will try to improve them. Just one very very little thing.

The version in your docker-compose.yml is now optional can be omitted. Furthermore the docker-compose.yml should now be compose.yml.

https://docs.docker.com/compose/compose-file/03-compose-file/

Last but not least the docker-compose up command should now be docker compose up. I am happy to submit a PR if you are open for that. As said JUST very small changes to reflect the latest updates in the Docker ecosystem.

Thanks for the great work!
Cheers

@tippexs tippexs changed the title No version needed in docker-compose.yml No version needed in docker-compose.yml and updates to reflect latest changes in the docker ecosystem Nov 7, 2023
@GeoffreyBooth
Copy link
Collaborator

Sure, a PR would be appreciated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants