Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused exchangeProxy in constants.ts #780

Open
Walodja1987 opened this issue Mar 28, 2023 · 0 comments
Open

Unused exchangeProxy in constants.ts #780

Walodja1987 opened this issue Mar 28, 2023 · 0 comments
Labels
code refactoring

Comments

@Walodja1987
Copy link
Collaborator

Context

It seems that exchangeProxy stored inside constants.ts is not used and instead the address is read via getContractAddressesForChainOrThrow from the @0x/contract-addresses package. See SellMarket.js file for instance.

I noticed that because the current Goerli exchangeProxy address is incorrect (0xdef1c0ded9bec7f1a1670819833240f027b25eff instead of 0xf91bb752490473b8342a3e964e855b9f9a2a668e), but 0x fill operations are still working.

Confirm and clean up.

image

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Walodja1987