Reset locale after suggest

Fixes #85

The reason we do this is because upper-/lowercasing requires a UTF-8
locale. However, some locales, e.g. nn_NO.UTF-8, also change things
like number formatting, so when changing the global process locale,
other programs called by divvun-checker will *next time around* start
using that locale.

This change simply reverts to the original locale after one round of
suggest. A better change might to use facets so the locale change
doesn't affect numbers.

Author: unhammer

src/suggest.cpp

@@ -1097,16 +1097,19 @@ void Suggest::mk_errs(Sentence& sentence) {
 }
 
 vector<Err> Suggest::run_errs(std::istream& is) {
+	std::locale old_locale = std::locale();
 	try {
-		auto _old = std::locale::global(std::locale(""));
+		old_locale = std::locale::global(std::locale("")); // Would prefer C.UTF-8, but that doesn't always exist
 	}
 	catch (const std::runtime_error& e) {
 		std::cerr
 		  << "divvun-suggest: WARNING: Couldn't set global locale \"\" "
 		     "(locale-specific native environment): "
 		  << e.what() << std::endl;
 	}
-	return run_sentence(is, FlushOn::Nul).errs;
+	auto result = run_sentence(is, FlushOn::Nul).errs;
+	std::locale::global(old_locale);
+	return result;
 }
 
 
@@ -1221,8 +1224,9 @@ RunState Suggest::run_cg(std::istream& is, std::ostream& os) {
 }
 
 void Suggest::run(std::istream& is, std::ostream& os, RunMode mode) {
+	std::locale old_locale = std::locale();
 	try {
-		auto _old = std::locale::global(std::locale(""));
+		old_locale = std::locale::global(std::locale("")); // Would prefer C.UTF-8, but that doesn't always exist
 	}
 	catch (const std::runtime_error& e) {
 		std::cerr
@@ -1244,6 +1248,7 @@ void Suggest::run(std::istream& is, std::ostream& os, RunMode mode) {
 			;
 		break;
 	}
+	std::locale::global(old_locale);
 }
 
 SortedMsgLangs sortMessageLangs(const MsgMap& msgs, const string& prefer) {