Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback plan for browsers that disable localStorage? #15

Open
carcinocron opened this issue Jul 17, 2015 · 2 comments
Open

Fallback plan for browsers that disable localStorage? #15

carcinocron opened this issue Jul 17, 2015 · 2 comments

Comments

@carcinocron
Copy link

Uncaught TypeError: Cannot call method 'getItem' of null
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.72 Safari/537.36

Here is the null.getItem() call:
https://github.com/diy/intercom.js/blob/master/lib/intercom.js#L38

Here is where I think we could change this:
https://github.com/diy/intercom.js/blob/master/lib/localstorage.js#L2

Perhaps we should check if localstorage is falsy in addition to undefined?

@PaitoAnderson
Copy link

+1

@estatematt
Copy link

+1 was writing something for iPad, this stopped me dead in my tracks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants