Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles not being rendered like ng2-smart-table #128

Closed
ColinM9991 opened this issue Apr 20, 2023 · 4 comments
Closed

Styles not being rendered like ng2-smart-table #128

ColinM9991 opened this issue Apr 20, 2023 · 4 comments
Labels
question A request for information, clarification, or support

Comments

@ColinM9991
Copy link

Hi,

I've recently picked up a pet project and have discovered that ng2-smart-table is no longer supported.

In order to continue using supported packages, I have discovered this fork. What I have observed is that, when following the steps outlined in the README, the styles aren't rendering correctly if at all, whereas ng2-smart-table renders correctly.

Are there any additional steps required in setting up angular2-smart-table?

@ColinM9991 ColinM9991 changed the title Styles not being rendered quite like ng2-smart-table Styles not being rendered like ng2-smart-table Apr 20, 2023
@uap-universe uap-universe added the question A request for information, clarification, or support label Apr 21, 2023
@uap-universe
Copy link
Collaborator

Hi! Welcome to our fork. Have you tried out the migration guide?
https://dj-fiorex.github.io/angular2-smart-table/migration
The styling drastically changed with the major upgrade to 2.x. Is there anything in particular, that you want back from the original style?

@ColinM9991
Copy link
Author

Hi! Welcome to our fork. Have you tried out the migration guide? https://dj-fiorex.github.io/angular2-smart-table/migration The styling drastically changed with the major upgrade to 2.x. Is there anything in particular, that you want back from the original style?

Thank you for your reply, and apologies if I took some time to get back to you - I was out of the country for a bit of time.

So here's what I see when I use ng2-smart-table
image

On the other hand, with ng2-smart-table, using the minimal example from the readme, this is what I first see
image

When I click the X next to ID then it changes to this
image

Although the original styling isn't in place anymore, it does feel like no styling is in place. Is this the expected behavior?

I wasn't previously aware of the guide that you've linked to, though I would recommend maybe adding a link to this in the readme. What I can see now, however, is that the Quick Start in the GitHub.IO also contains some incorrect import statements such as this - or at least I'm unable to find NgxSmartTableModule

import { NgxSmartTableModule } from 'angular2-smart-table';

@uap-universe
Copy link
Collaborator

To be honest, I have never read the quick start or the examples carefully, because when I joined this fork, I have already worked with the the lib for quite some time :-D
But there are certainly some flaws, that are now addressed in #129.

Regarding the styling I am quite confused about what is displayed in your screenshots. For example your pagination looks like this:
image

But it should look like this (with the new default style):
image

So my explanation would be:

  1. You have tried to bringt the old style back (like in the migration guide), but that turns out to be working far worse than expected
  2. There are some remnant stylesheets in your project folder that are accidentally applied and a clean rebuilt of the project tree might remove them.

@uap-universe
Copy link
Collaborator

Since there hasn't been activity for over one month now, I consider this as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question A request for information, clarification, or support
Projects
None yet
Development

No branches or pull requests

2 participants