Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTION] Rename Settings class to a less generic name #173

Open
joaoa-casagrande opened this issue Dec 21, 2024 · 0 comments
Open

[SUGGESTION] Rename Settings class to a less generic name #173

joaoa-casagrande opened this issue Dec 21, 2024 · 0 comments

Comments

@joaoa-casagrande
Copy link

In this example:

settings: Settings = {
  columns: {
    id: {
      title: 'ID'
    },
    name: {
      title: 'Full Name'
    },
    username: {
      title: 'User Name'
    },
    email: {
      title: 'Email'
    }
  }
};

The type of the settings property is called Settings, and with today's IDEs (like WebStorm), automatic import is a very handy feature.
So when a class has a common name, like Config or Settings instead of something more specific like Angular2SmartConfig or Angular2SmartSettings, it' becomes a hassle to import bacuse the IDE may import the wrong.
So maybe changing it to something more specific to this package may be better in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant