New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom filter forces the implementation of ngOnChanges #184

Open

uap-universe opened this issue Feb 20, 2025 · 0 comments

Labels

bug

Collaborator

uap-universe commented Feb 20, 2025

angular2-smart-table/projects/angular2-smart-table/src/lib/components/filter/custom-filter.component.ts

Line 31 in a48d020

this.customComponent.instance.ngOnChanges(changes);

Following options to solve this:

do not force the implementation
document it better and create a proper interface

uap-universe added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment