Don't allow slashes on filename

Author: rvlb

README.md

@@ -14,11 +14,12 @@ npm install --save-dev webpack-bundle-tracker
 This project is compatible with NodeJS versions 12 and up.
 
 ## Migrating from version 1.x.y to 2.x.y
-Starting on version 2.0.0, when creating a new instance of `BundleTracker`, the usage of the `path` parameter has been fixed and it's now being used to generate the output path for the stats file, together with the `filename` parameter. On version 2.0.0, if the `path` parameter is ommited from the constuctor call, it will attempt to place the stats file at the `output.path` directory (if also ommited, will use `'.'` as a fallback). To avoid that, when migrating, double-check if the file placement is as expected. The usage of these parameters is documented [here](#usage) and [here](#options).
+Starting on version 2.0.0, when creating a new instance of `BundleTracker`, the usage of the `path` parameter has been fixed and it's now being used to generate the output path for the stats file, together with the `filename` parameter. On version 2.0.0, if the `path` parameter is ommited from the constuctor call, it will attempt to place the stats file at the `output.path` directory (if also ommited, will use `'.'` as a fallback). Also, version 2.0.0 doesn't allow sub-directories to be included on the `filename`, only allowing to include them on the `path` param. To avoid those issues, when migrating, double-check if the file placement is as expected. The usage of these parameters is documented [here](#usage) and [here](#options).
 
 ## Usage
 
 ```javascript
+var path = require('path');
 var BundleTracker = require('webpack-bundle-tracker');
 module.exports = {
   context: __dirname,
@@ -27,15 +28,15 @@ module.exports = {
   },
 
   output: {
-    path: require('path').resolve('./assets/bundles/'),
+    path: path.resolve('./assets/bundles/'),
     filename: '[name]-[hash].js',
     publicPath: 'http://localhost:3000/assets/bundles/',
   },
 
   plugins: [
     new BundleTracker({
-      path: __dirname,
-      filename: 'assets/webpack-stats.json',
+      path: path.join(__dirname, 'assets'),
+      filename: 'webpack-stats.json',
     }),
   ],
 };

lib/index.js

@@ -84,6 +84,14 @@ class BundleTrackerPlugin {
       integrityHashes: ['sha256', 'sha384', 'sha512'],
     });
 
+    if (this.options.filename?.includes('/')) {
+      throw Error(
+        "The `filename` shouldn't include a `/`. Please use the `path` parameter to " +
+          "build the directory path and use `filename` only for the file's name itself.\n" +
+          'TIP: you can use `path.join` to build the directory path in your config file.',
+      );
+    }
+
     // Set output directories
     this.outputChunkDir = path.resolve(get(compiler.options, 'output.path', process.cwd()));
     // @ts-ignore: TS2345 this.options.path can't be undefined here because we set a default value above

tests/base.test.js

@@ -185,11 +185,11 @@ describe('BundleTrackerPlugin bases tests', () => {
     );
   });
 
-  it('It should create intermdiate directory if filename option is set with intermdiate directory', done => {
+  it('It should create intermdiate directory if path option is set with intermdiate directory', done => {
     const expectErrors = null;
     const expectWarnings = getWebpack4WarningMessage();
 
-    const filename = 'data/stats.json';
+    const filename = 'stats.json';
 
     testPlugin(
       webpack,
@@ -203,7 +203,7 @@ describe('BundleTrackerPlugin bases tests', () => {
         },
         plugins: [
           new BundleTrackerPlugin({
-            path: OUTPUT_DIR,
+            path: path.join(OUTPUT_DIR, 'data'),
             filename,
           }),
         ],
@@ -221,7 +221,7 @@ describe('BundleTrackerPlugin bases tests', () => {
           },
         },
       },
-      filename,
+      `data/${filename}`,
       done,
       expectErrors,
       expectWarnings,

tests/webpack5.test.js

@@ -185,11 +185,11 @@ describe('BundleTrackerPlugin bases tests', () => {
     );
   });
 
-  it('It should create intermdiate directory if filename option is set with intermdiate directory', done => {
+  it('It should create intermdiate directory if path option is set with intermdiate directory', done => {
     const expectErrors = null;
     const expectWarnings = getWebpack5WarningMessage();
 
-    const filename = 'data/stats.json';
+    const filename = 'stats.json';
 
     testPlugin(
       webpack5,
@@ -203,7 +203,7 @@ describe('BundleTrackerPlugin bases tests', () => {
         },
         plugins: [
           new BundleTrackerPlugin({
-            path: OUTPUT_DIR,
+            path: path.join(OUTPUT_DIR, 'data'),
             filename,
           }),
         ],
@@ -221,7 +221,7 @@ describe('BundleTrackerPlugin bases tests', () => {
           },
         },
       },
-      filename,
+      `data/${filename}`,
       done,
       expectErrors,
       expectWarnings,