Skip to content

Commit 3bd8c81

Browse files
committed
Excluded website Documents from DocsSitemap.
1 parent 9d7a08a commit 3bd8c81

File tree

3 files changed

+21
-25
lines changed

3 files changed

+21
-25
lines changed

docs/sitemaps.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from django.contrib.sitemaps import Sitemap
22

33
from .models import Document
4+
from .search import DocumentationCategory
45

56

67
class DocsSitemap(Sitemap):
@@ -10,6 +11,7 @@ def __init__(self, lang):
1011
def items(self):
1112
return (
1213
Document.objects.filter(release__lang=self.lang)
14+
.exclude(metadata__parents=DocumentationCategory.WEBSITE)
1315
.order_by("-release__release", "path")
1416
.select_related("release__release")
1517
)

docs/templates/docs/search_results.html

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,11 @@
2020
{% endfor %}
2121
</search>
2222
<h2>
23-
{% if release.is_dev %}
24-
{% blocktranslate count num_results=paginator.count trimmed %}
25-
{{ num_results }} result for <em>{{ query }}</em> in the development version
26-
{% plural %}
27-
{{ num_results }} results for <em>{{ query }}</em> in the development version
28-
{% endblocktranslate %}
29-
{% else %}
30-
{% blocktranslate count num_results=paginator.count trimmed %}
31-
{{ num_results }} result for <em>{{ query }}</em> in version {{ version }}
32-
{% plural %}
33-
{{ num_results }} results for <em>{{ query }}</em> in version {{ version }}
34-
{% endblocktranslate %}
35-
{% endif %}
23+
{% blocktranslate count num_results=paginator.count trimmed %}
24+
{{ num_results }} result for <em>{{ query }}</em>
25+
{% plural %}
26+
{{ num_results }} results for <em>{{ query }}</em>
27+
{% endblocktranslate %}
3628
</h2>
3729
{% else %}
3830
<h2>{% translate "No search query given" %}</h2>

docs/tests/test_views.py

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,7 @@ def test_search_type_filter_all(self):
9696
headers={"host": "docs.djangoproject.localhost:8000"},
9797
)
9898
self.assertEqual(response.status_code, 200)
99-
self.assertContains(
100-
response, "5 results for <em>generic</em> in version 5.1", html=True
101-
)
99+
self.assertContains(response, "5 results for <em>generic</em>", html=True)
102100
self.assertContains(response, self.active_filter, count=1)
103101
self.assertContains(response, f"{self.active_filter}All</a>", html=True)
104102

@@ -112,7 +110,7 @@ def test_search_type_filter_by_doc_types(self):
112110
self.assertEqual(response.status_code, 200)
113111
self.assertContains(
114112
response,
115-
"1 result for <em>generic</em> in version 5.1",
113+
"1 result for <em>generic</em>",
116114
html=True,
117115
)
118116
self.assertContains(response, self.active_filter, count=1)
@@ -127,9 +125,7 @@ def test_search_category_filter_invalid_doc_categories(self):
127125
headers={"host": "docs.djangoproject.localhost:8000"},
128126
)
129127
self.assertEqual(response.status_code, 200)
130-
self.assertContains(
131-
response, "5 results for <em>generic</em> in version 5.1", html=True
132-
)
128+
self.assertContains(response, "5 results for <em>generic</em>", html=True)
133129
self.assertContains(response, self.active_filter, count=1)
134130
self.assertContains(response, f"{self.active_filter}All</a>", html=True)
135131

@@ -143,9 +139,7 @@ def test_search_category_filter_no_results(self):
143139
self.assertContains(
144140
response, f"{self.active_filter}API Reference</a>", html=True
145141
)
146-
self.assertContains(
147-
response, "0 results for <em>potato</em> in version 5.1", html=True
148-
)
142+
self.assertContains(response, "0 results for <em>potato</em>", html=True)
149143
self.assertContains(
150144
response,
151145
'Please try searching <a href="?q=potato">all documentation results</a>.',
@@ -253,7 +247,7 @@ def test_code_links(self):
253247
self.assertEqual(response.status_code, 200)
254248
self.assertContains(
255249
response,
256-
f"1 result for <em>{query}</em> in version 5.1",
250+
f"1 result for <em>{query}</em>",
257251
html=True,
258252
)
259253
self.assertContains(response, expected_code_links, html=True)
@@ -282,7 +276,15 @@ def test_sitemap_index(self):
282276

283277
def test_sitemap(self):
284278
doc_release = DocumentRelease.objects.create()
285-
document = Document.objects.create(release=doc_release)
279+
document = Document.objects.create(
280+
release=doc_release,
281+
metadata={"parents": DocumentationCategory.TOPICS},
282+
)
283+
Document.objects.create(
284+
release=doc_release,
285+
metadata={"parents": DocumentationCategory.WEBSITE},
286+
path="example",
287+
)
286288
sitemap = DocsSitemap(settings.DEFAULT_LANGUAGE_CODE)
287289
urls = sitemap.get_urls()
288290
self.assertEqual(len(urls), 1)

0 commit comments

Comments
 (0)