Registration feat bis : this PR will cover the registration and resetting password functionality #25
Conversation
anjaniacatus
changed the title
There was a problem hiding this comment.
Good progress!
There are a few things in here that seem a little out of place. Not sure what parts of this ou re still working on.
I'm just wondering, did you consider using allauth or anything like that? It looks like there is still quite a lot of complicated code to write here.
core/urls.py
Outdated
|
|
||
| urlpatterns = [ | ||
| path("", include("website.urls")), | ||
| path("accounts/register/", custom_auth_views.register, name ="register"), |
There was a problem hiding this comment.
It might get a bit verbose if we need to include all the account urls here.
There will also be a bunch of stuff around forgotten passwords I think.
Can you not include the urls in bulk?
custom_auth/views.py
Outdated
| username = form.cleaned_data.get('username') | ||
| email = form.cleaned_data.get('email') | ||
| ######################### mail system #################################### | ||
| template_email = get_template('registration/registration_email.html') |
There was a problem hiding this comment.
How about putting this in a seperate function. eg: send_registration_email()?
This will make the code clearer and easier to test
| @@ -0,0 +1,5 @@ | |||
| {% autoescape off %} | |||
There was a problem hiding this comment.
It might be cool to put the email templates in a different directory so they are easy to find.
Eg templates/registration/emails
| dict(email=u.email), | ||
| format="text/html") | ||
| email_lines = mail.outbox[0].body.splitlines() | ||
| reset_password_url = email_lines[2].replace(" ", "") |
There was a problem hiding this comment.
This seems very odd - why is itnecessary to change the url in otder to make the url valid? Should the url not just work as is?
|
|
||
| import pytest | ||
|
|
||
| class UserTestCase(TestCase): |
There was a problem hiding this comment.
I haven't seen people combine pytest and unittest at the beginning of a project before.
One of the main reasons people like to use pytest is because it doesn't need so much boilerplate, but this is written in a way that it does need the boilerplate.
i will check that |
No description provided.