Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how to remove animator from entity #121

Open
extrawurst opened this issue Mar 17, 2024 · 2 comments
Open

how to remove animator from entity #121

extrawurst opened this issue Mar 17, 2024 · 2 comments
Labels
question Further information is requested

Comments

@extrawurst
Copy link

extrawurst commented Mar 17, 2024 •
edited
Loading

As far as i can see the Animator<> is generic over the Tweenable and that becomes very hairy and bespoke for each tween generated to be able to remove the whole Animator again from an entity.

What is the best practice here?
@djeedai
Copy link
Owner

djeedai commented Mar 17, 2024

Animator<> is generic over the target Component because you need to declare the system parameters at build time for Bevy to work (at least until we get dynamic queries). I think the best practice is not to remove the Animator at all; what are you concerned about leaving it?

@djeedai djeedai added the question Further information is requested label Apr 24, 2024
@djeedai
Copy link
Owner

djeedai commented Apr 27, 2024

See also #111 and #122 for discussions, in case what you meant is how to remove once the animation is done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@extrawurst @djeedai