Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

chuniio: Support 6-ray keyboard-mapped AIR sensors - [opened] #39

Open
icex2 opened this issue Jan 30, 2020 · 2 comments
Open

chuniio: Support 6-ray keyboard-mapped AIR sensors - [opened] #39

icex2 opened this issue Jan 30, 2020 · 2 comments

Comments

@icex2
Copy link

icex2 commented Jan 30, 2020

In GitLab by @ilufang on Jan 30, 2020, 05:21

Merges air-dev -> master

Added option to directly populate beams from custom AIR hardware that reports 6 individual IR rays. The hardware would generate a keyboard press when a ray is broken and release when not for 6 distinct keys. Also see updated segatools.ini.

@icex2
Copy link
Author

icex2 commented Feb 18, 2020

In GitLab by @tau on Feb 18, 2020, 01:31

Commented on chuniio/chuniio.c line 77

Ahh, damn. This looks like it's actually a bug in chunihook/jvs.c, specifically the ordering of the chunithm_jvs_ir_masks[] array. Fixing it is an API break, but I think on balance we should bite the bullet and fix the problem in chunihook itself.

(Sorry for taking so long to get around to reviewing this patch by the way, it looks good otherwise)

@icex2
Copy link
Author

icex2 commented Feb 18, 2020

In GitLab by @ilufang on Feb 18, 2020, 08:49

Commented on chuniio/chuniio.c line 77

No problem. Agree that the hook should be fixed to leave a clean API. For my part reverting 6e34fcc should be good enough. Feel free to do it or let me know if it is a good time to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant