Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HSV<->RGB conversion functions #4

Open
run4flat opened this issue Jan 19, 2012 · 3 comments
Open

Remove HSV<->RGB conversion functions #4

run4flat opened this issue Jan 19, 2012 · 3 comments

Comments

@run4flat
Copy link
Collaborator

Maggie is adding these to a PDL::Graphics::ColorSpace module, so I do not need them anymore. The only thing I do need to provide is RGB->PrimaColor, along with the associated transforms.

@mohawk2
Copy link
Contributor

mohawk2 commented Feb 14, 2022

It may be relevant that there's also a https://metacpan.org/pod/PDL::Transform::Color - but if Maggie's module needs updating, let me know as I have permissions on it.

@mohawk2
Copy link
Contributor

mohawk2 commented Jan 16, 2023

Update on this: I have very recently updated P:T:C to use P:G:CS, and updated that to be so usable. I recommend P:G:CS for all this sort of stuff.

@mohawk2
Copy link
Contributor

mohawk2 commented Jan 16, 2023

Further notes: having now read through the code, this module's needs are different from those solved by P:G:CS; that uses double for each colour-component (RGB, HSV, etc), while this module uses float+ for HSV, and a 32-bit int for RGB (one byte per R, G, B). Therefore, I think this issue does not need solving!

However, I do think it would be valuable to add literally any tests at all for the conversion utilities, and cribbing those from P:G:CS would make it super-easy, barely an inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants