Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

videoPercentage is passed from React component to JS class but ignored #120

Open
BThero opened this issue Sep 13, 2024 · 0 comments
Open

videoPercentage is passed from React component to JS class but ignored #120

BThero opened this issue Sep 13, 2024 · 0 comments

Comments

@BThero
Copy link

BThero commented Sep 13, 2024

Here in the ScrollyVideo.jsx component, we can see videoPercentage being passed into the JS class.

But a quick CMD+F in the ScrollyVideo.js file reveals that the passed value is not used at all. Not sure how this affects things, but might be a cause for some unintended bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BThero