Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when not accessing member variable through this #942

Open
cwinter158 opened this issue Dec 5, 2023 · 0 comments
Open

Warn when not accessing member variable through this #942

cwinter158 opened this issue Dec 5, 2023 · 0 comments

Comments

@cwinter158
Copy link

What are thoughts on issuing a warning when accessing a member variable without going through the this reference?

struct A {
    int i;

    this(int i)
    {
        i = i; // <-- Warning
        this.i = i; // <-- Ok
    }
}

My request is motivated by the specific issue highlighted in this example, but this check in general would remove some ambiguities, especially in constructors (I don't know easy it would be to limit the check to constructors, though).

It would surely be extremely noisy for most projects, so maybe would make most sense to be disabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant