Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #20644 cast(ref T) as shorthand for *cast(T*)& #20728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #20644 cast(ref T) as shorthand for *cast(T*)& #20728

wants to merge 1 commit into from
+59 −2

Conversation

WalterBright
Copy link
Member

A simple rewrite.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20728"

@WalterBright
Copy link
Member Author

#20644

@thewilsonator thewilsonator added Review:Needs Changelog A changelog entry needs to be added to /changelog Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org labels Jan 18, 2025
thewilsonator
thewilsonator reviewed Jan 18, 2025
View reviewed changes
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs Spec PR and changelog (and probably DIP?) but otherwise looks good

@JohanEngelen
Copy link
Contributor

JohanEngelen commented Jan 18, 2025 •
edited
Loading

Edit: moved my comment to here: #20644 (comment)

@WalterBright WalterBright mentioned this pull request Jan 18, 2025
Open
@WalterBright
Copy link
Member Author

Spec PR: dlang/dlang.org#4164

@WalterBright WalterBright removed the Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org label Jan 18, 2025
@WalterBright WalterBright removed the Review:Needs Changelog A changelog entry needs to be added to /changelog label Jan 18, 2025
@dkorpel dkorpel linked an issue Jan 20, 2025 that may be closed by this pull request
cast(ref T)... as shorthand for *cast(T*)&... #20644
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanEngelen JohanEngelen JohanEngelen left review comments

@thewilsonator thewilsonator thewilsonator left review comments

Assignees
No one assigned
Labels
Review:Easy Review Review:Pending DIP Approval Severity:Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cast(ref T)... as shorthand for *cast(T*)&...
5 participants
@WalterBright @dlang-bot @JohanEngelen @thewilsonator @dkorpel