Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nom=4.2.3 contains code that will be rejected by a future version of Rust #8

Open
wsowens opened this issue Feb 9, 2024 · 2 comments

Comments

@wsowens
Copy link

wsowens commented Feb 9, 2024

Hi there, thanks for your work on this project!

I got a compiler warning in a project that sues gb-io:

warning: the following packages contain code that will be rejected by a future version of Rust: nom v4.2.3
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`

This is fixed in subsequent version of nom. It looks like #7 already addresses this issue, but the PR is still open. As someone currently using this package, I figured I would make this issue to say 1) I appreciate this package and 2) it would also appreciate if #7 could be merged at some point.

Also happy to lend a hand if there are still any difficulties porting from nom 4 to nom 7.

@dlesl
Copy link
Owner

dlesl commented Feb 9, 2024

Hi, it's been a while since I looked at it but I think that #7 is complete in that all the tests pass, looking at the code there is still a FIXME around error handling (stream_parser.rs, maybe other places too?) which would be good to get fixed before merging. If you have some time to take a look at that, and also generally just testing the branch with your project I would really appreciate it.

I appreciate this package

Thanks!

@althonos
Copy link
Contributor

@dlesl : I can compile gb-io.py without any change using the nom-7 branch, and it passes the downstream Python tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants