Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import schemas not working #1004

Closed
rudolfix opened this issue Feb 26, 2024 · 2 comments · Fixed by #1013
Closed

Fix import schemas not working #1004

rudolfix opened this issue Feb 26, 2024 · 2 comments · Fixed by #1013
Assignees
Labels
bug Something isn't working community This issue came from slack community workspace

Comments

@rudolfix
Copy link
Collaborator

Background
Users report that the https://dlthub.com/docs/walkthroughs/adjust-a-schema does not work anymore. We should reproduce the workflow and make sure it is OK. What is reported:

  • schemas in import folder are overwritten on each run
  • when full refresh is used, schemas are overwritten with some weird names
@rudolfix rudolfix added the community This issue came from slack community workspace label Feb 26, 2024
@sh-rp sh-rp self-assigned this Feb 27, 2024
@sh-rp sh-rp moved this from Todo to Planned in dlt core library Feb 27, 2024
@sh-rp sh-rp added the bug Something isn't working label Feb 27, 2024
@sh-rp
Copy link
Collaborator

sh-rp commented Feb 27, 2024

Both reports do not seem to be correct (i will follow up with the reporter though), what does seem to be the case though is, that the hints and columns added in the import schema are not respected at all.

@sh-rp
Copy link
Collaborator

sh-rp commented Feb 27, 2024

When full_refresh is false, the import schema gets overwritten.

@sh-rp sh-rp moved this from Planned to In Progress in dlt core library Feb 27, 2024
@sh-rp sh-rp changed the title adjust schema walkthrough reported not to work Fix import schemas not working Feb 27, 2024
@sh-rp sh-rp linked a pull request Feb 27, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in dlt core library Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community This issue came from slack community workspace
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants