Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select_union insert values writer type fails with buffered writing #1173

Closed
jorritsandbrink opened this issue Apr 2, 2024 · 0 comments · Fixed by #1174
Closed

select_union insert values writer type fails with buffered writing #1173

jorritsandbrink opened this issue Apr 2, 2024 · 0 comments · Fixed by #1174
Assignees
Labels
bug Something isn't working

Comments

@jorritsandbrink
Copy link
Collaborator

dlt version

0.4.7

Describe the problem

User report: https://dlthub-community.slack.com/archives/C04DQA7JJN6/p1711839048557919
image

The cause of this issue is the fact that buffer chunk separation does not differentiate between default and select_union insert values writes type (only logic for default is implemented).

Expected behavior

select_union insert values writer type works properly, also when the number of items exceed the configured max_buffer_size.

Steps to reproduce

os.environ["DATA_WRITER__BUFFER_MAX_ITEMS"] = "5"  # set buffer size less than number of data items
pipeline = dlt.pipeline(pipeline_name="bug", destination="synapse", full_refresh=True)
pipeline.run([{"id": i} for  i in range(10)], table_name="items") 

Operating system

Windows

Runtime environment

Local

Python version

3.8

dlt data source

No response

dlt destination

No response

Other deployment details

No response

Additional information

No response

@jorritsandbrink jorritsandbrink added the bug Something isn't working label Apr 2, 2024
@jorritsandbrink jorritsandbrink self-assigned this Apr 2, 2024
@jorritsandbrink jorritsandbrink moved this from Todo to In Progress in dlt core library Apr 2, 2024
@jorritsandbrink jorritsandbrink linked a pull request Apr 2, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in dlt core library Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant