Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTClient: Create a page-based paginator. #1205

Closed
burnash opened this issue Apr 10, 2024 · 1 comment
Closed

RESTClient: Create a page-based paginator. #1205

burnash opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@burnash
Copy link
Collaborator

burnash commented Apr 10, 2024

Feature description

Create a new paginator, e.g. PageNumberPaginator, which relies on incrementing page numbers for the case where total pages or total records is known.

Are you a dlt user?

Yes, I'm already a dlt user.

Use case

Paginating the RESTful APIs

Proposed solution

A new paginator, PageNumberPaginator that accepts page number parameter name (page_param, defaulting to "page").

Should be able to handle simple page-based API pagination which is missing the url to next page but contains total number of pages. E.g. https://uriyyo-fastapi-pagination.netlify.app/

Related issues

@burnash burnash self-assigned this Apr 10, 2024
@burnash burnash added the enhancement New feature or request label Apr 10, 2024
@rudolfix rudolfix moved this from Todo to In Progress in dlt core library Apr 15, 2024
@rudolfix rudolfix added the sprint Marks group of tasks with core team focus at this moment label Apr 25, 2024
@burnash burnash moved this from In Progress to Done in dlt core library May 7, 2024
@burnash
Copy link
Collaborator Author

burnash commented May 7, 2024

Implemented in #1307

@burnash burnash closed this as completed May 7, 2024
@rudolfix rudolfix removed the sprint Marks group of tasks with core team focus at this moment label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants