Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semver minimum version requirement #2115

Closed
vdorie opened this issue Dec 2, 2024 · 0 comments · Fixed by #2132
Closed

semver minimum version requirement #2115

vdorie opened this issue Dec 2, 2024 · 0 comments · Fixed by #2132
Labels
bug Something isn't working

Comments

@vdorie
Copy link

vdorie commented Dec 2, 2024

dlt version

1.4.0

Describe the problem

semver is listed as requiring >=2.13.0, however semver.Version (referenced in a few places, including here) was only introduced with version 3.0.0. This causes dlt to fail at import on systems with semver already installed at 2.13.0, giving:

AttributeError: module 'semver' has no attribute 'Version'

Expected behavior

dlt should be able to be used on systems that meet its stated requirements.

Steps to reproduce

python3 -m venv test_env
source test_env/bin/activate
pip install semver==2.13.0 dlt
import dlt

Operating system

Linux, macOS

Runtime environment

Local

Python version

3.11

dlt data source

No response

dlt destination

No response

Other deployment details

No response

Additional information

It looks as if semver.Version was introduced with 47633c6, so the issue also impacts 1.3.0.

@rudolfix rudolfix added the bug Something isn't working label Dec 9, 2024
@rudolfix rudolfix moved this from Todo to In Progress in dlt core library Dec 9, 2024
@sh-rp sh-rp linked a pull request Dec 10, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in dlt core library Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants