Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more credential sources in dlt CLI #2139

Open
3 of 6 tasks
trymzet opened this issue Dec 11, 2024 · 0 comments
Open
3 of 6 tasks

Support more credential sources in dlt CLI #2139

trymzet opened this issue Dec 11, 2024 · 0 comments

Comments

@trymzet
Copy link
Contributor

trymzet commented Dec 11, 2024

Feature description

Currently, the CLI only works when specifying credentials in 3 out of 6 possible ways:

  • secrets.toml
  • config.toml
  • environment variables
  • custom config providers
  • parameters specified in the pipeline
    For example,
    pipeline = dlt.pipeline(..., destination=dlt.destinations.clickhouse(credentials=my_credentials))
  • dynamically provided credentials
    For example, dlt.secrets["my-secret"] = "my_dynamic_secret_value"

In practical terms, this makes eg. using a secret manager for storing credentials troublesome, because users need to have one of the 3 static credential sources available locally, which basically defeats the purpose of using an external secret manager.

Are you a dlt user?

None

Use case

No response

Proposed solution

Probably creds passed via the credentials param should be prioritized, as some of the tutorials use this method of providing credentials (eg. https://dlthub.com/docs/pipelines/sql_database_mssql/load-data-with-python-from-sql_database_mssql-to-mssql#5-next-steps-to-get-your-pipeline-running-in-production), which means if you followed the tutorial, you would end up unable to use dlt CLI commands.

Related issues

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant