You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Background
With #746 destinations can be used like sources (imported and then parametrized). Here we add more flexibility on how to configure them,
*Tasks
in DestinationClientConfiguration rename destination_name to destination_type: it is a Final (non configurable) field (we can convert it into class var as well)
add name field which defaults to destination_type if not provided.
use the ability of with_config to accept section as lambda that takes the arguments of the function to generate dynamic config section for a destination: [destination.<name>], please fix with_config signature and add unit test for it
add environment (str) config field with default None
each destination factory must accept the base fields of DestinationClientConfiguration (name, environment, credentials) and expose them as attributes
Implementation
This probably impacts #746 - we should get rid of current destination reference and most of the init of implementation in favor of destination factory.
relevant part of with_config that deals with dynamic sections
# if section derivation function was provided then call it
if section_f:
curr_sections: Tuple[str, ...] = (section_f(bound_args.arguments), )
# sections may be a string
elif isinstance(sections, str):
curr_sections = (sections,)
else:
curr_sections = sections
The text was updated successfully, but these errors were encountered:
Background
With #746 destinations can be used like sources (imported and then parametrized). Here we add more flexibility on how to configure them,
*Tasks
DestinationClientConfiguration
renamedestination_name
todestination_type
: it is a Final (non configurable) field (we can convert it into class var as well)name
field which defaults todestination_type
if not provided.with_config
to accept section as lambda that takes the arguments of the function to generate dynamic config section for a destination:[destination.<name>]
, please fixwith_config
signature and add unit test for itenvironment
(str) config field with default NoneDestinationClientConfiguration
(name, environment, credentials) and expose them as attributesImplementation
This probably impacts #746 - we should get rid of current destination reference and most of the
init
of implementation in favor of destination factory.relevant part of
with_config
that deals with dynamic sectionsThe text was updated successfully, but these errors were encountered: