Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ibis az problems on linux #2135

Merged
merged 4 commits into from
Dec 16, 2024
Merged

fix ibis az problems on linux #2135

merged 4 commits into from
Dec 16, 2024

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Dec 11, 2024

Description

Reverse order of doing things when creating the ibis backend to see wether we can fix the problems with azure.

@sh-rp sh-rp marked this pull request as ready for review December 11, 2024 10:57
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit da975d6
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/675ef86acf0550000850d372
😎 Deploy Preview https://deploy-preview-2135--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sh-rp sh-rp changed the title [do not merge] try to fix ibis az problems on linux fix ibis az problems on linux Dec 11, 2024
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged a hack into destinations.yaml that links certs in a proper place. IMO you should remove it and run the CI again

@rudolfix
Copy link
Collaborator

@sh-rp now it fails again...

@sh-rp
Copy link
Collaborator Author

sh-rp commented Dec 12, 2024

@rudolfix yeah, i don't know why...

@sh-rp
Copy link
Collaborator Author

sh-rp commented Dec 13, 2024

¯_(ツ)_/¯

@sh-rp sh-rp closed this Dec 13, 2024
@rudolfix
Copy link
Collaborator

@sh-rp heh that was tricky. actually SET was executed on a clone of the connection, while ibis was using another clone. And SET is not shared. pls check my commit and review

@rudolfix rudolfix reopened this Dec 15, 2024
Copy link
Collaborator Author

@sh-rp sh-rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, the tests also pass, thanks for figuring this out!

@sh-rp sh-rp self-assigned this Dec 16, 2024
@sh-rp sh-rp requested a review from rudolfix December 16, 2024 09:35
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rudolfix rudolfix merged commit 4a051b0 into devel Dec 16, 2024
50 of 72 checks passed
@rudolfix rudolfix deleted the tests/fix_az_ibis_tests branch December 16, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants