Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include author-role indicator in the UI for PRs and issues #515

Open
sideshowbarker opened this issue Jan 28, 2025 · 0 comments · May be fixed by #516
Open

Include author-role indicator in the UI for PRs and issues #515

sideshowbarker opened this issue Jan 28, 2025 · 0 comments · May be fixed by #516

Comments

@sideshowbarker
Copy link
Contributor

sideshowbarker commented Jan 28, 2025

Describe the solution you'd like

For PRs, I’d like the UI to show a “this is first-time contributor” indicator similar in some way to what the GitHub UI shows.

But if we’re going to show that, it seems like we should just go ahead also always some indicator of the author’s role with respect to the repo to which the PR was submitted. I mean, “contributor”, “member”, “owner” etc.

We can get that author-role data with the API — from the value of the pull_request.author_association field. The values NONE, FIRST_TIMER, or FIRST_TIME_CONTRIBUTOR all basically indicate “first-time contributor”. See the details at https://michaelheap.com/github-actions-check-permission/.

Describe alternatives you've considered
I haven’t considered any alternatives.

Additional context

Use case: I’m one of the core reviewers for MDN Web Docs, and each week we get a significant number of people contributing docs patches to MDN for the first time. In those cases, I like to post a special comment welcoming them and thanking them for their first contribution.

Example: mdn/content#37835 (comment)

And when I have a lot of “Needs My Review” PRs to triage, I personally also like to give some priority to the first-time-contributor PRs over PRs from returning contributors — or minimally, I try to make sure those first-time-contributor PRs don’t sit for too long without me or somebody else taking time to comment, at least just to give them some estimate of when we’ll be able to actually review the PR. And I especially like to make sure that those first-time contributor PRs don’t end going unhandled for so long that a project stale bot ends up auto-closing them

Implementing

I’d be willing to contribute a patch myself — once I get familiar enough with the code to be able to write up patch.

But if somebody else gets it implemented in the meantime, that’d be great too.

@sideshowbarker sideshowbarker changed the title Include “First-time contributor” indicator in the Preview for PRs Include “First-time contributor” indicator in the UI for PRs Jan 28, 2025
@sideshowbarker sideshowbarker changed the title Include “First-time contributor” indicator in the UI for PRs Include “First-time contributor” etc indicator in the UI for PRs Jan 28, 2025
@sideshowbarker sideshowbarker changed the title Include “First-time contributor” etc indicator in the UI for PRs Include author-role indicator in the UI for PRs Jan 30, 2025
@sideshowbarker sideshowbarker changed the title Include author-role indicator in the UI for PRs Include author-role indicator in the UI for PRs and issues Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant