From 814386f2c38e89ade70a3c7b2cf93b0bbc155c10 Mon Sep 17 00:00:00 2001 From: "Dustin L. Howett" Date: Thu, 10 Mar 2022 18:30:24 -0500 Subject: [PATCH] Revert "Make sure Terminal Stable shows up default on 22544+" (#12664) This reverts commit 457738e388a60e3d2d62736e006e4e407d5e81e8. --- src/internal/stubs.cpp | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/internal/stubs.cpp b/src/internal/stubs.cpp index 5a047da742e..da6423d14ec 100644 --- a/src/internal/stubs.cpp +++ b/src/internal/stubs.cpp @@ -40,16 +40,9 @@ void EdpPolicy::AuditClipboard(const std::wstring_view /*destinationName*/) noex [[nodiscard]] HRESULT DefaultApp::CheckShouldTerminalBeDefault(bool& isEnabled) noexcept { - // Since we toggled this feature on in Windows, Terminal (and Terminal Preview) need to - // agree -- otherwise, they will present UI that suggests Terminal is NOT the default, - // like the info bar. - OSVERSIONINFOEXW osver{}; - osver.dwOSVersionInfoSize = sizeof(osver); - osver.dwBuildNumber = 22544; - - DWORDLONG dwlConditionMask = 0; - VER_SET_CONDITION(dwlConditionMask, VER_BUILDNUMBER, VER_GREATER_EQUAL); - - isEnabled = VerifyVersionInfoW(&osver, VER_BUILDNUMBER, dwlConditionMask) != FALSE; + // False since setting Terminal as the default app is an OS feature and probably + // should not be done in the open source conhost. We can always decide to turn it + // on in the future though. + isEnabled = false; return S_OK; }