fix: read exactly 8 bytes even when receiving whole file

dmacvicar · Oct 24, 2024 · 451ea03 · 451ea03
1 parent 26e70c9
commit 451ea03
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/libvirt/volume_image.go b/libvirt/volume_image.go
@@ -144,16 +144,17 @@ func (i *httpImage) IsQCOW2() (bool, error) {
 			response.Status)
 	}
 
-	header, err := io.ReadAll(response.Body)
+	header := make([]byte, 8)
+	n, err := io.ReadFull(response.Body, header)
 	if err != nil {
 		return false, err
 	}
 
-	if len(header) < 8 {
+	if n < 8 {
 		return false, fmt.Errorf(
 			"can't retrieve read header of resource to determine file type: %s - %d bytes read",
 			i.url.String(),
-			len(header))
+			n)
 	}
 
 	return isQCOW2Header(header)