Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful shutdown of domain resource when recreate is required #1060

Open
karelvanhecke opened this issue Dec 27, 2023 · 3 comments
Open

Graceful shutdown of domain resource when recreate is required #1060

karelvanhecke opened this issue Dec 27, 2023 · 3 comments
Labels
Feedback wanted Important (Wanted) Feature or contribution desired to be had and merged

Comments

@karelvanhecke
Copy link

System Information

Linux distribution

CentOS Stream 8

Terraform version

$ terraform -v
Terraform v1.6.6
on linux_amd64
+ provider registry.terraform.io/dmacvicar/libvirt v0.7.6

Provider and libvirt versions

dmacvicar/libvirt v0.7.6
libvirtd (libvirt) 8.0.0

Description of Issue/Question

Currently, when a domain resource has been modified and requires a recreate, the domain is destroyed and recreated.
While this is the most performant solution, it isn't necessarily the safest when you consider that the attached volumes aren't necessarily destroyed and recreated.

This could in theory lead to data corruption.

In #356 graceful shutdown was proposed, but this issue was closed.

@marshallford
Copy link

I'm interested in this feature as well, particularly for the use case of running immutable infrastructure with Fedora CoreOS or Flatcar Container Linux where the established pattern is to replace VMs when making configuration/version changes (with ignition) rather than using a config mgmt tool over the top.

@Silvenga
Copy link

Silvenga commented Apr 5, 2024

This seems important, as changing the memory of a domain will cause the domain to be replaced. This means the next boot of the same volume will be after an unclean shutdown.

@scabala
Copy link
Contributor

scabala commented Sep 2, 2024

Related to #1069
However, graceful shutdown is important feature by itself.

@dmacvicar dmacvicar added Important (Wanted) Feature or contribution desired to be had and merged Feedback wanted labels Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback wanted Important (Wanted) Feature or contribution desired to be had and merged
Projects
None yet
Development

No branches or pull requests

5 participants