Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying of target host machine on every individual resource/data source #1072

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from

Commits on Dec 20, 2023

  1. Configuration menu
    Copy the full SHA
    ba090fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    19893fc View commit details
    Browse the repository at this point in the history
  3. move authentication parsing to per host part of loop

    this allows different hosts (jump hosts) to have different identity files
    specified
    Memet Bilgin committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    94ae671 View commit details
    Browse the repository at this point in the history
  4. implement per Host identity file lookup

    Memet Bilgin committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    76ed8d0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7dacf0b View commit details
    Browse the repository at this point in the history
  6. updated go.sum

    Memet Bilgin committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    7273b7d View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. cleanup log outputs

    Memet Bilgin committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    4abb01a View commit details
    Browse the repository at this point in the history
  2. remove unnecessary local variable

    Memet Bilgin committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f190d80 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2023

  1. Add none option to graphics

    flx5 committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    401c36c View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. make use of net package URI building to support correct ipv6

    as per commit from MaxMatti:
    dmacvicar@1152bdd
    Memet Bilgin committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    329a202 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. correctly use host:port format when dialing bastion host

    Memet Bilgin committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    c1e4fbf View commit details
    Browse the repository at this point in the history
  2. put quotes around target in case it is empty

    Memet Bilgin committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    100f82b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e203600 View commit details
    Browse the repository at this point in the history
  4. add log output for port override

    Memet Bilgin committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    d47102d View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. add a node info query data source

    allow querying VM Host capabilities so that we can make decisions on what
    resources to deploy. This can be things like machine architecture, but possibly
    also to deploy VMs in a CPU topology manner
    Memet Bilgin committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    35d6a04 View commit details
    Browse the repository at this point in the history
  2. add a preliminary test

    however tests aren't running right project wide and there will need to be a PR
    to address this
    Memet Bilgin committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    5f61a7b View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. add readme entry for modification

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    2a12896 View commit details
    Browse the repository at this point in the history
  2. update provider and config structure

    provider now only stores the default URI but does no book-keeping of its own,
    instead the Client class is used to manage provider connections
    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    82b491d View commit details
    Browse the repository at this point in the history
  3. rename config to client to match implemented classes

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    c20d2db View commit details
    Browse the repository at this point in the history
  4. remove locking from volume.go as this is an abstraction leak

    the lock is acquired after two calls to retrieve the volume pool and key. While
    this is a potential slow down in those events where either one isn't found, it's
    probably not a problem to be concerned about.
    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    781ad9e View commit details
    Browse the repository at this point in the history
  5. update cloudinit implementations to match new architecture

    1. remove the lock management from the cloudinit_def as this is an abstraction
    leak (also, the lock is acuqired very early in the call and has no performance
    penalty unless there is a lookup failure)
    2. fetch local `host` value when obtaining a connection or use default provider
    URI instead if not found
    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    673e954 View commit details
    Browse the repository at this point in the history
  6. update all networking implementations (same comments as 673e954)

    1. move lock ownership to upper layer
    2. obtain network connection on each action
    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    fdd1a32 View commit details
    Browse the repository at this point in the history
  7. add per connection mutex' for speed up and abstraction leak fix

    if we are connecting to multiple servers for simulatenous creation of volumes,
    there's no need to do this sequentially across all servers
    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    12199ef View commit details
    Browse the repository at this point in the history
  8. make use of per-connection locking mechanism

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    c8facd8 View commit details
    Browse the repository at this point in the history
  9. add default host key algorithm

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1516454 View commit details
    Browse the repository at this point in the history
  10. move port configuration earlier so that hostkey callback works right

    the hostKeyCallback makes use of the SSH port and fails if a custom ssh port is
    being used by the host
    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    7caaf18 View commit details
    Browse the repository at this point in the history
  11. cleanup log output, add error handling for dial host

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    ad51d68 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6754108 View commit details
    Browse the repository at this point in the history
  13. integrate HostKeyAlgorithms ssh_config option

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    60cf3f1 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    060987d View commit details
    Browse the repository at this point in the history
  15. add comments

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    31af282 View commit details
    Browse the repository at this point in the history
  16. use a more modern default host key

    this value was chosen as the lowest RSA available by default on a debian build
    running OpenSSH_9.2 and works out of the box for most hosts tested by authority.
    Any older systems can specifically set their key algorithms in .ssh/config
    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    3680059 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    615b189 View commit details
    Browse the repository at this point in the history
  18. add readme entry for modification

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    6407d2b View commit details
    Browse the repository at this point in the history
  19. update provider and config structure

    provider now only stores the default URI but does no book-keeping of its own,
    instead the Client class is used to manage provider connections
    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    18fe843 View commit details
    Browse the repository at this point in the history
  20. rename config to client to match implemented classes

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    9dff3e0 View commit details
    Browse the repository at this point in the history
  21. remove locking from volume.go as this is an abstraction leak

    the lock is acquired after two calls to retrieve the volume pool and key. While
    this is a potential slow down in those events where either one isn't found, it's
    probably not a problem to be concerned about.
    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    2291b1b View commit details
    Browse the repository at this point in the history
  22. update cloudinit implementations to match new architecture

    1. remove the lock management from the cloudinit_def as this is an abstraction
    leak (also, the lock is acuqired very early in the call and has no performance
    penalty unless there is a lookup failure)
    2. fetch local `host` value when obtaining a connection or use default provider
    URI instead if not found
    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    cc90152 View commit details
    Browse the repository at this point in the history
  23. update all networking implementations (same comments as 673e954)

    1. move lock ownership to upper layer
    2. obtain network connection on each action
    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    da5cda1 View commit details
    Browse the repository at this point in the history
  24. Merge branch 'ssh-config-parameters' into production

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    88946d3 View commit details
    Browse the repository at this point in the history
  25. Merge branch 'multi-connection-private' into production

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    0dff8f9 View commit details
    Browse the repository at this point in the history
  26. update error string to match resource arguments

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    9306274 View commit details
    Browse the repository at this point in the history
  27. update error string to match resource arguments

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    171ce55 View commit details
    Browse the repository at this point in the history
  28. correctly deal with default uri/host args

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    580e778 View commit details
    Browse the repository at this point in the history
  29. add trace log to output default URI

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    776958c View commit details
    Browse the repository at this point in the history
  30. correctly deal with default uri/host args

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b2d024b View commit details
    Browse the repository at this point in the history
  31. correctly deal with default uri/host args (same as 580e778)

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    6228a00 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    082f086 View commit details
    Browse the repository at this point in the history
  33. Merge branch 'ssh-config-parameters' into production

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a88abaf View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    dec8f23 View commit details
    Browse the repository at this point in the history
  35. Merge branch 'ssh-config-parameters' into production

    Memet Bilgin committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    3053906 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Merge branch 'main' into multi-connection

    Memet Bilgin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    816d963 View commit details
    Browse the repository at this point in the history
  2. add multi-host code for missing data sources

    Memet Bilgin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    892b1b6 View commit details
    Browse the repository at this point in the history
  3. remove incorrectly included file from feature branch

    Memet Bilgin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b503b73 View commit details
    Browse the repository at this point in the history
  4. update error messages to match source location

    Memet Bilgin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    46215ff View commit details
    Browse the repository at this point in the history
  5. Merge branch 'main' into production

    Memet Bilgin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a6fd68c View commit details
    Browse the repository at this point in the history
  6. remove node info data source impl from dmacvicar#1059

    Memet Bilgin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1768b27 View commit details
    Browse the repository at this point in the history
  7. rename node-info impl to match other data sources

    Memet Bilgin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    efd8262 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    57b3c57 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'production' of github.com:memetb/terraform-provider-lib…

    …virt into production
    Memet Bilgin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e0c49a9 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #6 from memetb/graphics-none-option

    Add none option to graphics
    memetb authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    112116a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    93188e4 View commit details
    Browse the repository at this point in the history
  12. Revert "Add none option to graphics"

    This reverts commit 401c36c.
    Memet Bilgin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c42a1fc View commit details
    Browse the repository at this point in the history
  13. remove duplicated file

    Memet Bilgin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    0db9931 View commit details
    Browse the repository at this point in the history
  14. remove duplicated data source entry

    Memet Bilgin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    4671752 View commit details
    Browse the repository at this point in the history