-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knownhosts tilde aware path expansion - fixes #1107 #1115
Open
memetb
wants to merge
15
commits into
dmacvicar:main
Choose a base branch
from
memetb:knownhosts-tilde-aware-expansion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memetb
commented
Oct 23, 2024
previously this code would hand back the path as specified by the caller if it failed (a path which can be a user specified string). However, this would mean that the returned entity would be a string or a filepath depending on the codepath. This behaviour previously existed in the codebase, however it is not clear if it caused any issues anywhere in production. This PR, including the associated unit test shows that under at least some circumstances (github ci) the outcomes are unexpected.
I won't call this monkey patching. It is just a drop-in replacement function. The part I think we can improve is the naming. We are replacing os.ExpandEnv, which expands generic string, for something that is specialized into paths, so why not just Even its argument is called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This directly addresses issue #1107 but is also a small refactor effort to move some utility code into the util package with associated unit tests.
The specific changes are to move the file path expansion code to a dedicated utility function in the util package and add an associated unit test.
As a note, issue #1107 is legacy to v0.8.x and existed before here.