Enhancement: Add domain title property #1126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1041
Adds basic support for managing a libvirt domain title property.
Possible further improvements:
have a
CustomDifffunction that checks if a new title is valid (read: contains no newline characters) BEFORE attempting to replace a domain. Right now when the new title contains newlines the user can still attempt a replacement, the previous domain is destroyed and the new one fails to be created because the title is invalid.No bueno.
do not force a replacement when the title changes and correctly update it in place. I think libvirt API has no function to update only the title property, so this may require directly updating the domain XML configuration and redefining the domain.