Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript support? #11

Open
ivank opened this issue Sep 17, 2020 · 1 comment
Open

Typescript support? #11

ivank opened this issue Sep 17, 2020 · 1 comment

Comments

@ivank
Copy link

ivank commented Sep 17, 2020

First of all thank you very much for this package, it just blew my mind with its elegance!

I wanted to write some types in DefinitlyTyped for it, but the esm modules don't work well with type script for some reason.

Currently I've just copy-pasted the code to our project and added types, but I'd be happy to help with making it available in TS, though I'm not sure how to go about it.

What do you think?

@dmaevsky
Copy link
Owner

Ivan,
Sorry for the late reply, and thank you for kind words :)
Any help is definitely appreciated. We are actively using rd-parse in a number of quite large projects, all of them in plain old JS though. So I don't have much experience with TS to be honest. What is exactly the problem with esm modules in TS? Could you point me to some code I could play with and reproduce error messages if any ?
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants