-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to not advertise upon startup #27
base: main
Are you sure you want to change the base?
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.38%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
hello? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched to your branch and it works fine. I justed added some suggestion to the YAML example. I can't say much about the code, but I would be happy if @dmamontov could have a look.
Thanks for the review! Your changes have been committed. |
Co-authored-by: Johannes Dilli <[email protected]>
Co-authored-by: Johannes Dilli <[email protected]>
Co-authored-by: Johannes Dilli <[email protected]>
With some devices, it is preferable simply not to advertise at all the return of the ESP keyboard once it restarts.
This option enables users to choose that.
They can create a switch to turn advertisements off in this way: