Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookies check can generate very long URLs #128

Open
hmoffatt opened this issue Jan 31, 2024 · 1 comment
Open

cookies check can generate very long URLs #128

hmoffatt opened this issue Jan 31, 2024 · 1 comment

Comments

@hmoffatt
Copy link
Contributor

The cookies check takes the original login POST and turns it into a GET. I have one LMS which includes an lti_message_hint that is nearly 4k long, and this is then added to the URL.

I think the cookies check javascript could still re-send the request as a POST and this would avoid the very long URLs. The server side is only looking for the existence of the lti1p3_new_window field to determine if the check has been run or not, not the HTTP method.

@hmoffatt
Copy link
Contributor Author

Although it's all got to go in the authentication callback to the tool consumer anyway, which is another GET, so this doesn't matter I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant