Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the recommended way to use? #73

Open
ShayBox opened this issue Jul 11, 2020 · 1 comment
Open

What's the recommended way to use? #73

ShayBox opened this issue Jul 11, 2020 · 1 comment

Comments

@ShayBox
Copy link

ShayBox commented Jul 11, 2020

Should you use the official maven repo, jitpack, or local build and shadow it into your jar, or copy the entire project into your project, and if the latter, should you include everything, or go through and copy only the things you use, also should you keep the package path the same or change it to avoid conflicting with other plugins that include it.

I've found plugins doing all of this, even a plugin that modified this into a plugin and had the user install it in their server's plugin folder, so which one is recommended by you, Thanks.

EDIT: Unrelated but WrapperPlayServerCustomPayload and WrapperPlayClientCustomPayload getContents() is modifying the original data, causing the data to be deleted when using the method, use .copy() on the buffer.

@dmulloy2
Copy link
Owner

It's recommended to copy the classes you need into your project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants