Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge crab rest, log pipeline, and serviceaccount manifests together in single helm chart #8677

Open
novicecpp opened this issue Aug 30, 2024 · 5 comments · Fixed by dmwm/CMSKubernetes#1545
Assignees

Comments

@novicecpp
Copy link
Contributor

I would like to commit the new serviceaccount for CI to CMSKuberentes but I do not know where to put it. Also, the crab's logstash manifests is in different place.

After discuss with @arooshap, she suggested to put everything together in single helm chart, helm/crabserver, and use value flags to render specific resources groups.

We have 3 resource group:

For example, the values-testX.yaml only for render crabserver-related manifests:

environment: "test"
enabled: true
image:
  tag: "pypi-test12-manual1"

To render log pipeline and CI serviceaccount (e.g., values-admin.yaml), the value file will look like this:

environment: "preprod"
enabled: false
logPipeline:
  enabled: true
ciServiceAccount:
  enabled: true

This will be easier for cluster admin to maintain all our services.
And for us, we only need to focus on modifying the crabserver resourec group, e.g., adding a new canary deployment.

@novicecpp novicecpp self-assigned this Aug 30, 2024
@novicecpp
Copy link
Contributor Author

@belforte @aspiringmind-code I would like to hear your comment about a new config directory structure.

  • config/{test,preprod,prod}/config.py for rest config config.py (move from crab-secrets/kuberentes)
  • config/{test,preprod,prod}/logstash.conf for logstash config

Here is the full directory structure:

[thanayut@localhost beautify]$ tree .
.
├── Chart.yaml
├── config
│   ├── preprod
│   │   ├── config.py
│   │   └── logstash
│   │       ├── logstash.conf
│   │       └── logstash.yml
│   └── test
│       ├── config.py
│       └── logstash
│           ├── logstash.conf
│           └── logstash.yml
├── deploy.sh
├── README.md
├── scripts
│   └── setup.sh
├── templates
│   ├── ci-serviceaccount-rbac.yaml
│   ├── ci-serviceaccount-secret.yaml
│   ├── ci-serviceaccount.yaml
│   ├── configMap.yaml
│   ├── deployment-canary.yaml
│   ├── deployment.yaml
│   ├── filebeat-configmap.yaml
│   ├── filebeat-daemonset.yaml
│   ├── _helpers.tpl
│   ├── hpa.yaml
│   ├── ingress.yaml
│   ├── logstash-configmap.yaml
│   ├── logstash-deployment.yaml
│   ├── logstash-service.yaml
│   ├── serviceaccount.yaml
│   └── service.yaml
├── values-canary.yaml
├── values-genall.yaml
├── values-logpipeline.yaml
├── values-prod.yaml
├── values-test11.yaml
├── values-test12.yaml
├── values-test14.yaml
├── values-test2.yaml
├── values-testbed.yaml
└── values.yaml

8 directories, 38 files

What do you think?

@novicecpp
Copy link
Contributor Author

You can view these files in my fork here: https://github.com/novicecpp/CMSKubernetes/tree/crab_canary/helm/crabserver

@belforte
Copy link
Member

I like it

@novicecpp
Copy link
Contributor Author

This is done, merge to CMSKubernetes, and documents.

@novicecpp
Copy link
Contributor Author

Sorry. I need to keep this open because it does not deploy on production yet.

test (at least test12) and preprod are now use new helm chart.

@novicecpp novicecpp reopened this Oct 31, 2024
@novicecpp novicecpp removed their assignment Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants