Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fix for process controller scripts (manage.sh/manage.py/etc.) #8737

Merged
merged 10 commits into from
Oct 17, 2024

Conversation

novicecpp
Copy link
Contributor

@novicecpp novicecpp commented Oct 11, 2024

All tested except the last bullet.

@cmsdmwmbot

This comment was marked as outdated.

@belforte
Copy link
Member

belforte commented Oct 11, 2024

thanks, superquick. Yet I do not understand the first commit, I was running from /data cwd

typing /data/start.sh with a cwd other than /data fails immediately with No such file or directory: './manage.sh' which is all in all OK

i.e. this may be nice, but does not appear related to the problem that PYTHONPATH is not changed when using -g. Or is that due to the $DEBUG bug as well ?

@belforte
Copy link
Member

hmm.. looks to me that $MODE is set in manage.py but never used

@novicecpp
Copy link
Contributor Author

Yeah....I just discover while testing this script.
The new commits I pushed should fix many issues I found so far, including #8707 and #8707 (sorry for stealing Vijay task).

@cmsdmwmbot

This comment was marked as outdated.

@novicecpp novicecpp changed the title Fix manage sh py Various fix for process controller scripts (manage.sh/manage.py/etc.) Oct 11, 2024
@novicecpp
Copy link
Contributor Author

@belforte I have updated this PR description.
I will leave this until Tuesday in case you have any question.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
    • 1 comments to review
  • Pycodestyle check: succeeded
    • 12 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2195/artifact/artifacts/PullRequestReport.html

@novicecpp novicecpp merged commit 34bb7e5 into dmwm:master Oct 17, 2024
2 checks passed
@novicecpp novicecpp self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a status.sh to containers
3 participants