Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra quotes in setup.py break other tools #17

Open
michaelaye opened this issue Dec 27, 2019 · 4 comments
Open

Extra quotes in setup.py break other tools #17

michaelaye opened this issue Dec 27, 2019 · 4 comments

Comments

@michaelaye
Copy link

In your setup.py these extra ' quotes break conda builds and are not required, I think:

"yapf >= '0.28'; python_version < '3.6'",
"black >= '19.3'; python_version >= '3.6'",

I think they should be better:

"yapf >= 0.28; python_version < 3.6",
"black >= 19.3; python_version >= 3.6",

Maybe you try if your build process works without them (I think they should) and then you could remove these quotes?

@dnanhkhoa
Copy link
Owner

Thank you @michaelaye, I will update it soon.

@homocomputeris
Copy link

Also, in setup.py, both master and dev have

name="nb_black",
    version="1.0.6",

but on PyPI it's 1.0.7.

Iain-S pushed a commit to Iain-S/nb_black that referenced this issue Aug 19, 2020
@Iain-S Iain-S mentioned this issue Aug 19, 2020
dnanhkhoa added a commit that referenced this issue Aug 23, 2020
@nivintw
Copy link

nivintw commented Sep 18, 2020

It looks like master has been updated with the PR to fix this issue, but a new version hasn't been pushed to PyPI. Please push an update to PyPI so users don't have to install from source. Thanks!

@PaulJWright
Copy link

This issue is still a problem: https://pypi.org/project/nb-black/#files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants