Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Can now click on arrow when text is highlighted to expand/collapse #3780

Closed
wants to merge 1 commit into from

Conversation

tariknh
Copy link

@tariknh tariknh commented Jul 16, 2024

Fixes #3750

This removes the previous: user-select: none; // prevent selection on double-click .

If by selection they meant text highlight, then this previous fix i removed only solved double clicking on the arrow only.

as it prevented clicking on the accordion arrow
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 11:20pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker
Copy link
Member

Thank you for this PR 🫶

Looking at it, we should keep the user-select: none; because it serves a different issue.
To fix the overall downside reported #3750, we should fix this issue on the JavaScript side and where the "prevent click" check happens. Its located in the onClickTr handler inside TableClickableHead.tsx file.

@tujoworker tujoworker closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants