Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Normal users with edit permissions can enter edit mode but cannot leave #6363

Open
2 tasks done
enfJoao opened this issue Feb 8, 2025 · 2 comments
Open
2 tasks done

Comments

@enfJoao
Copy link

enfJoao commented Feb 8, 2025

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

The only way to (normally) leave edit mode is through the close button on the bottom bar that shows on edit mode. No such bar on edit permission.

Steps to reproduce?

Give a normal user the edit or content permissions to a page.
Login as this normal user.
Enter edit mode clicking the pencil icon on the PB.
The bottom bar never shows, so the only way to exit edit mode is to move away from the page.

Current Behavior

Bottom bar does not show, so no way to exit edit mode.

Image

Expected Behavior

SuperUser:
Image

Relevant log output

Anything else?

The edit mode makes sense for edit permission.
Does it also make sense for the new "Content" permission?
Many content editors (specially for 2sxc) should not have access to the PB or edit mode.

Affected Versions

10.0.0 (alpha)

What browsers are you seeing the problem on?

Firefox

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mitchelsellers
Copy link
Contributor

Are you using the newer enhanced permission setup? If so was ONLY edit page given?

@enfJoao
Copy link
Author

enfJoao commented Feb 9, 2025

Yep. Fresh DNN 10 with minimal changes and testing.

Sorry, but the behavior of the edit mode is too unreliable to replicate. Every time I test I get slightly different result. This is somewhat common:

View + (Add or Copy or Export or Import) Permissions:
PB shows. Edit icon shows, no tooltip.
Click causes 401 on /API/internalservices/controlBar/ToggleUserMode

View + Manage Permissions:
PB shows. Edit icon shows, no tooltip.
Click causes no visible changes.

View + Navigate:
No PB.

View + Add Permissions:
PB shows. Edit icon shows, no tooltip.
Click works and enters edit mode. No bottom bar. "Click to lock Edit Mode..." tooltip now shows.
Clicking the pencil icon again toogles the cookie StayInEditMode, but does not exit edit mode.
To effectively exit the edit mode I have to click the icon and set StayInEditMode to "NO", and move away from the page. But this is not shown in any UI (the dark shade in the icon even seems reversed). If the cookie is set to "YES", nothing I do (move away, logout and login) exits edit mode.

Edit permission just toogles all other permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants