diff --git a/CHANGELOG.md b/CHANGELOG.md index c4b4db5..dcc727a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/). ## main +- CHANGED: Deprecated `from` and `to` fields in `EmailForward` + ## 1.0.0 - CHANGED: Drop support for Rust < 1.76 diff --git a/src/dnsimple/domains_email_forwards.rs b/src/dnsimple/domains_email_forwards.rs index 0f20a94..a591fe9 100644 --- a/src/dnsimple/domains_email_forwards.rs +++ b/src/dnsimple/domains_email_forwards.rs @@ -21,8 +21,10 @@ pub struct EmailForward { /// The destination email pub destination_email: String, /// The "local part" of the originating email address. Anything to the left of the @ symbol. + #[deprecated(note = "use alias_email instead")] pub from: String, /// The full email address to forward to. + #[deprecated(note = "use destination_email instead")] pub to: String, /// When the email forward was created in DNSimple. pub created_at: String, diff --git a/tests/domains_email_forwards_test.rs b/tests/domains_email_forwards_test.rs index 822d19c..fe57a60 100644 --- a/tests/domains_email_forwards_test.rs +++ b/tests/domains_email_forwards_test.rs @@ -19,18 +19,19 @@ fn test_list_email_forwards() { .unwrap(); let email_forwards_list = response.data.unwrap(); - assert_eq!(2, email_forwards_list.len()); + assert_eq!(1, email_forwards_list.len()); let email_forwards = email_forwards_list.first().unwrap(); - assert_eq!(17702, email_forwards.id); - assert_eq!(228963, email_forwards.domain_id); + assert_eq!(24809, email_forwards.id); + assert_eq!(235146, email_forwards.domain_id); assert_eq!(".*@a-domain.com", email_forwards.from); assert_eq!("jane.smith@example.com", email_forwards.to); - assert_eq!("2016-02-04T13:59:29Z", email_forwards.created_at); - assert_eq!("2016-02-04T13:59:29Z", email_forwards.updated_at); + assert_eq!("2017-05-25T19:23:16Z", email_forwards.created_at); + assert_eq!("2017-05-25T19:23:16Z", email_forwards.updated_at); } +#[allow(deprecated)] #[test] fn test_create_email_forward() { let setup = setup_mock_for( @@ -63,6 +64,7 @@ fn test_create_email_forward() { assert_eq!("example@example.com", record.to); } +#[allow(deprecated)] #[test] fn test_get_email_forward() { let setup = setup_mock_for( diff --git a/tests/fixtures/v2/api/createEmailForward/created.http b/tests/fixtures/v2/api/createEmailForward/created.http index e4ca82e..0c96a16 100644 --- a/tests/fixtures/v2/api/createEmailForward/created.http +++ b/tests/fixtures/v2/api/createEmailForward/created.http @@ -2,6 +2,7 @@ HTTP/1.1 201 Created Server: nginx Date: Mon, 25 Jan 2021 13:54:40 GMT Content-Type: application/json; charset=utf-8 +Transfer-Encoding: identity Connection: keep-alive X-RateLimit-Limit: 4800 X-RateLimit-Remaining: 4772 diff --git a/tests/fixtures/v2/api/getEmailForward/success.http b/tests/fixtures/v2/api/getEmailForward/success.http index 14e31e8..8e54bba 100644 --- a/tests/fixtures/v2/api/getEmailForward/success.http +++ b/tests/fixtures/v2/api/getEmailForward/success.http @@ -2,6 +2,7 @@ HTTP/1.1 200 OK Server: nginx Date: Mon, 25 Jan 2021 13:56:24 GMT Content-Type: application/json; charset=utf-8 +Transfer-Encoding: identity Connection: keep-alive X-RateLimit-Limit: 4800 X-RateLimit-Remaining: 4766 diff --git a/tests/fixtures/v2/api/listEmailForwards/success.http b/tests/fixtures/v2/api/listEmailForwards/success.http index 4a5a99a..4dd4074 100644 --- a/tests/fixtures/v2/api/listEmailForwards/success.http +++ b/tests/fixtures/v2/api/listEmailForwards/success.http @@ -1,16 +1,16 @@ HTTP/1.1 200 OK Server: nginx -Date: Thu, 04 Feb 2016 14:07:19 GMT +Date: Fri, 17 May 2024 09:07:28 GMT Content-Type: application/json; charset=utf-8 Connection: keep-alive -Status: 200 OK -X-RateLimit-Limit: 4000 -X-RateLimit-Remaining: 3993 -X-RateLimit-Reset: 1454596043 -ETag: W/"3f10aae0cf0f0b81bdb4f58786ee1750" +X-RateLimit-Limit: 4800 +X-RateLimit-Remaining: 4748 +X-RateLimit-Reset: 1715936948 +X-WORK-WITH-US: Love automation? So do we! https://dnsimple.com/jobs +ETag: W/"a5eed9a071f03e10fc67001ccc647a94" Cache-Control: max-age=0, private, must-revalidate -X-Request-Id: 6e3aa9d0-cb95-4186-93b0-630da372de86 -X-Runtime: 0.026287 -Strict-Transport-Security: max-age=31536000 +X-Request-Id: e42df983-a8a5-4123-8c74-fb89ab934aba +X-Runtime: 0.025456 +Strict-Transport-Security: max-age=63072000 -{"data":[{"id":17702,"domain_id":228963,"from":".*@a-domain.com","to":"jane.smith@example.com","created_at":"2016-02-04T13:59:29Z","updated_at":"2016-02-04T13:59:29Z"},{"id":17703,"domain_id":228963,"from":"john@a-domain.com","to":"john@example.com","created_at":"2016-02-04T14:07:13Z","updated_at":"2016-02-04T14:07:13Z"}],"pagination":{"current_page":1,"per_page":30,"total_entries":2,"total_pages":1}} +{"data":[{"id":24809,"domain_id":235146,"alias_email":".*@a-domain.com","destination_email":"jane.smith@example.com","created_at":"2017-05-25T19:23:16Z","updated_at":"2017-05-25T19:23:16Z","from":".*@a-domain.com","to":"jane.smith@example.com"}],"pagination":{"current_page":1,"per_page":30,"total_entries":1,"total_pages":1}}