New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO #1

Open

6 tasks done

dobbse42 opened this issue Mar 5, 2020 · 0 comments

Labels

TODO

Owner

dobbse42 commented Mar 5, 2020 •

edited

Loading

write ctrladd function
move qubit creation to separate function
fix ancillary qubit location
write pseudocode for the multiplier
implement pseudocode
write testing code (displays two summands and sum, two factors and product)

Questions:

Should buffer zeroes be added in the implementation by the user or by the multiplier/adder themselves?
Should I move the toffoli step in the multiplier to it's own class as I did the adder?
What is the standard on using moments (e.g. for the toffolis) versus simply appending a circuit to another?

dobbse42 added the TODO label

dobbse42 pushed a commit that referenced this issue


          Merge pull request #1 from dobbse42/master

46aa1d2

controlled addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment