Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize internal ListWorkers calls #2474

Open
tonistiigi opened this issue May 25, 2024 · 0 comments
Open

Optimize internal ListWorkers calls #2474

tonistiigi opened this issue May 25, 2024 · 0 comments
Assignees
Labels
area/buildkit help wanted Extra attention is needed kind/enhancement New feature or request
Milestone

Comments

@tonistiigi
Copy link
Member

Atm. every client.Build call calls ListWorkers internally https://github.com/moby/buildkit/blob/v0.13.2/client/build.go#L31 . Buildx makes one such call for build node to determine its capabilities, and another per build request. Docker driver makes additional call to detect Moby snapshotter capability. While the call is fast, it is still unnecessary and could be optimized to avoid that. It also shows up in opentelemetry trace and could be confusing.

Options could be to add some internal caching in buildkit client or allow passing the workers list into Build() with some option. Avoiding the request for Docker driver likely requires update to driver interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/buildkit help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants