docker-engine: remove devicemapper dependencies #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
remove-devicemapper
branch
from
f0a73c6 to
598c612
Compare
crazy-max
changed the title
thaJeztah
approved these changes
Oct 21, 2023
| @@ -188,7 +188,7 @@ ARG DOCKER_ENGINE_REF | |||
| ARG NIGHTLY_BUILD | |||
| WORKDIR /build | |||
| ARG TARGETPLATFORM | |||
| RUN xx-apt-get install -y gcc libc6-dev libapparmor-dev libdevmapper-dev libltdl-dev libseccomp-dev libsecret-1-dev libsystemd-dev libudev-dev pkg-config | |||
| RUN xx-apt-get install -y gcc libc6-dev libapparmor-dev libltdl-dev libseccomp-dev libsecret-1-dev libsystemd-dev libudev-dev pkg-config | |||
There was a problem hiding this comment.
interesting actually that we had to manually install these; didn't we let the rpm/deb tools handle install dependencies?
There was a problem hiding this comment.
This stage is to build static binaries like docker/docker-ce-packaging#835
There was a problem hiding this comment.
In the future if I can rely on upstream Dockerfiles I could just use the right remote target and avoid redefining this stage.
There was a problem hiding this comment.
Oh! Yes for the static binaries it makes sense
neersighted
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up docker/docker-ce-packaging#959