Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tree] parent parameter typing in updateNode method (Nested strategy) #2816

Open
dt-haithem-bouassida opened this issue Jun 11, 2024 · 1 comment
Open

[Tree] parent parameter typing in updateNode method (Nested strategy) #2816

dt-haithem-bouassida opened this issue Jun 11, 2024 · 1 comment

Comments

@dt-haithem-bouassida
Copy link

Feature Request

This concerns the method updateNode of Nested strategy (src/Tree/Strategy/ORM/Nested.php).
According to the PHPDoc, we expect $parent parameter to be Node|object, but we accept/handle the case of a null parent inside this method.
This is problematic for PHPStan.
Could you please fix

Thank you
@dt-haithem-bouassida dt-haithem-bouassida changed the title $parent parameter typing in updateNode method (Nested strategy) [Tree] $parent parameter typing in updateNode method (Nested strategy) Jun 11, 2024
@dt-haithem-bouassida dt-haithem-bouassida changed the title [Tree] $parent parameter typing in updateNode method (Nested strategy) [Tree] parent parameter typing in updateNode method (Nested strategy) Jun 11, 2024
@mbabker
Copy link
Contributor

mbabker commented Jun 12, 2024

Feel free to send a pull request with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbabker @dt-haithem-bouassida