From 50ebbab707268df24d5da2ff77973f6a19024d5f Mon Sep 17 00:00:00 2001 From: Renaud Date: Mon, 14 Oct 2024 14:34:00 +0200 Subject: [PATCH 1/3] Fix casting issue due to MariaDB not included in inheritance schema anymore --- src/Translatable/Query/TreeWalker/TranslationWalker.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Translatable/Query/TreeWalker/TranslationWalker.php b/src/Translatable/Query/TreeWalker/TranslationWalker.php index 2c5be1564..4801ad4d1 100644 --- a/src/Translatable/Query/TreeWalker/TranslationWalker.php +++ b/src/Translatable/Query/TreeWalker/TranslationWalker.php @@ -10,8 +10,8 @@ namespace Gedmo\Translatable\Query\TreeWalker; use Doctrine\DBAL\Connection; +use Doctrine\DBAL\Platforms\AbstractMySQLPlatform; use Doctrine\DBAL\Platforms\AbstractPlatform; -use Doctrine\DBAL\Platforms\MySQLPlatform; use Doctrine\DBAL\Platforms\PostgreSQLPlatform; use Doctrine\DBAL\Types\Type; use Doctrine\ORM\Mapping\ClassMetadata; @@ -308,9 +308,9 @@ private function prepareTranslatedComponents(): void // Treat translation as original field type $fieldMapping = $meta->getFieldMapping($field); - if ((($this->platform instanceof MySQLPlatform) + if ((($this->platform instanceof AbstractMySQLPlatform) && in_array($fieldMapping['type'], ['decimal'], true)) - || (!($this->platform instanceof MySQLPlatform) + || (!($this->platform instanceof AbstractMySQLPlatform) && !in_array($fieldMapping['type'], ['datetime', 'datetimetz', 'date', 'time'], true))) { $type = Type::getType($fieldMapping['type']); From abdd260b2e55d6a84f87cdb219e50c5ac7c8b2d3 Mon Sep 17 00:00:00 2001 From: Renaud Date: Tue, 15 Oct 2024 23:48:31 +0200 Subject: [PATCH 2/3] Add CHANGELOG.md log entry --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 594bf72d2..0d24f9c39 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,8 @@ a release. --- ## [Unreleased] +### Fixed +- Fix regression with `doctrine/dbal` >= 4.0 that caused MariaDB to improperly try to CAST to LONGTEXT in TranslationWalker (issue #2887) ## [3.17.1] - 2024-10-07 ### Fixed From a40a3e01278b21992a4443afa710afcd137bf4bd Mon Sep 17 00:00:00 2001 From: Renaud Grand Date: Wed, 16 Oct 2024 09:02:50 +0200 Subject: [PATCH 3/3] Update CHANGELOG.md Co-authored-by: Javier Spagnoletti --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0d24f9c39..a814c1fcb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,7 +19,7 @@ a release. ## [Unreleased] ### Fixed -- Fix regression with `doctrine/dbal` >= 4.0 that caused MariaDB to improperly try to CAST to LONGTEXT in TranslationWalker (issue #2887) +- Fix regression with `doctrine/dbal` >= 4.0 that caused MariaDB to improperly attempt LONGTEXT casting in `TranslationWalker` (issue #2887) ## [3.17.1] - 2024-10-07 ### Fixed