Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

StreamClient does not support https #71

Open
paulmer opened this issue Jan 20, 2017 · 3 comments
Open

StreamClient does not support https #71

paulmer opened this issue Jan 20, 2017 · 3 comments

Comments

@paulmer
Copy link

paulmer commented Jan 20, 2017

lib/Doctrine/CouchDB/HTTP/StreamClient has a hard coded protocol of http with a "TODO" comment to support SSL. I suggest at a minimum the attached patch to set the protocol based on the ssl option flag. Since the library supports the inherently insecure basic http authentication protocol, SSL support is very important.
@paulmer
Copy link
Author

paulmer commented Jan 20, 2017

patch.txt

@damiankloip
Copy link
Contributor

See #70

@damiankloip
Copy link
Contributor

@paulmer you can also use our fork, which has that fix in already, https://github.com/relaxedws/couchdb-client

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damiankloip @paulmer