skip identifier field in computeChangeSet

Author: GromNaN

lib/Doctrine/ODM/MongoDB/UnitOfWork.php

@@ -761,6 +761,11 @@ private function computeOrRecomputeChangeSet(ClassMetadata $class, object $docum
                     continue;
                 }
 
+                // skip identifier field
+                if (in_array($propName, $class->getIdentifierFieldNames(), true)) {
+                    continue;
+                }
+
                 $orgValue = $originalData[$propName] ?? null;
 
                 // skip if value has not changed

tests/Doctrine/ODM/MongoDB/Tests/UnitOfWorkTest.php

@@ -20,6 +20,7 @@
 use Documents\File;
 use Documents\FileWithoutMetadata;
 use Documents\ForumAvatar;
+use Documents\ForumStar;
 use Documents\ForumUser;
 use Documents\Functional\NotSaved;
 use Documents\User;
@@ -497,6 +498,34 @@ public function testRecomputeChangesetForUninitializedProxyDoesNotCreateChangese
         self::assertEquals([], $this->uow->getDocumentChangeSet($user->getAvatar()));
     }
 
+    /**
+     * Native lazy ghosts objects are marked as initialized when the last property
+     * is set. It appends when the document class has only one property: the id.
+     */
+    public function testRecomputeChangesetForNativeLazyGhostWithOnlyIdDoesNotCreateChangeset(): void
+    {
+        $user           = new ForumUser();
+        $user->username = '12345';
+        $user->setStar(new ForumStar());
+
+        $this->dm->persist($user);
+        $this->dm->flush();
+
+        $id = $user->getId();
+        $this->dm->clear();
+
+        $user = $this->dm->find(ForumUser::class, $id);
+        self::assertInstanceOf(ForumUser::class, $user);
+
+        self::assertTrue(self::isLazyObject($user->getStar()));
+
+        $classMetadata = $this->dm->getClassMetadata(ForumStar::class);
+
+        $this->uow->recomputeSingleDocumentChangeSet($classMetadata, $user->getStar());
+
+        self::assertEquals([], $this->uow->getDocumentChangeSet($user->getStar()));
+    }
+
     public function testCommitsInProgressIsUpdatedOnException(): void
     {
         $this->dm->getEventManager()->addEventSubscriber(

tests/Documents/ForumAvatar.php

@@ -9,7 +9,9 @@
 #[ODM\Document]
 class ForumAvatar
 {
-    /** @var string|null */
     #[ODM\Id]
-    public $id;
+    public ?string $id;
+
+    #[ODM\Field]
+    public ?string $url = null;
 }

tests/Documents/ForumStar.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Documents;
+
+use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
+
+/**
+ * Special entity that only has the $id field.
+ */
+#[ODM\Document]
+class ForumStar
+{
+    #[ODM\Id]
+    public ?string $id;
+}

tests/Documents/ForumUser.php

@@ -22,6 +22,9 @@ class ForumUser
     #[ODM\ReferenceOne(targetDocument: ForumAvatar::class, cascade: ['persist'])]
     public $avatar;
 
+    #[ODM\ReferenceOne(targetDocument: ForumStar::class, cascade: ['persist'])]
+    public ?ForumStar $star;
+
     /** @return int|ObjectId|null */
     public function getId()
     {
@@ -42,4 +45,14 @@ public function setAvatar(ForumAvatar $avatar): void
     {
         $this->avatar = $avatar;
     }
+
+    public function getStar(): ForumStar
+    {
+        return $this->star;
+    }
+
+    public function setStar(ForumStar $star): void
+    {
+        $this->star = $star;
+    }
 }