Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan level 6 #2384

Open
2 tasks
franmomu opened this issue Nov 1, 2021 · 1 comment
Open
2 tasks

PHPStan level 6 #2384

franmomu opened this issue Nov 1, 2021 · 1 comment

Comments

@franmomu
Copy link
Contributor

franmomu commented Nov 1, 2021

It would be nice to reach level 6 for 2.3, but that would require quite some work, apart from #2383, there are two more checks to reach that level:

  • checkGenericClassInNonGenericObjectType (198 errors): This one, every generic class should have defined its type/s.
  • checkMissingIterableValueType (498 errors): This one means that every iterable should define the type of the items.

For the first one, we should probably bump to PHPStan 1 (to be able to use array as template type), but we'll see. I'll try to provide PRs with small changes when I find some time.

@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Apr 18, 2022
@malarzm malarzm removed the Stale Issues that have not seen any activity in 30 days label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants