updateMany() does not serialize EmbeddedDocument documents in embedded documents fields.

[landure]

Bug Report

Q	A
BC Break	yes
Version	2.12.1

Summary

Current behavior

updateMany() accepts to set EmbeddedDocument in fields (field name is field.target) but it stores an empty document {} in the target field.
It works for root fields (field name is target).

I believe this worked in version 2.7.0.

How to reproduce

use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;

#[ODM\EmbeddedDocument()]
class Embedded {
 public function __construct(
        #[ODM\Field(type: 'string')]
        #[ODM\Index()]
        private string $name,
}
}

#[ODM\EmbeddedDocument()]
class RootEmbedded {
 public function __construct(
        #[ODM\EmbedOne(targetDocument: Embedded::class)]
        private Embedded $embedded;
}
}

#[ODM\Document()]
class MainDocument {
    #[ODM\EmbedOne(targetDocument: RootEmbedded::class)]
        private RootEmbedded $field;

        #[ODM\EmbedOne(targetDocument: Embedded::class)]
        private Embedded $embedded;
}

In MainDocumentRepository:

        $qb = $this->createQueryBuilder();
        $qb->updateMany()
            ->field('root.embedded.name')->equals($embedded->getName())
            ->field('embedded')->set($embedded)  // works
            ->field('root.embedded')->set($embedded) // doesn't work, store `{}`
            ->getQuery()
            ->execute();

Expected behavior

updateMany() accepts to set EmbeddedDocument in fields of embedded documents (when the field name is field.target), and stores the full document { "name": "value" } in the target field.

[GromNaN]

Hi Pierre-Yves, nice to see you here.

The fact you get an empty object proves that Doctrine does not encode the embedded document into BSON. Since we support converting documents into references, it should be possible to encode embedded documents. That's a new feature.

[landure]

Hi Jérôme, I've updated the issue to match the broken behavior. It's something that was working previously.

[landure]

I've identified that the issue is in DocumentPersister::prepareQueryElement() processing of field names containing dots.

As far as I understand, It's not recursive for embedded one mappings.
For field.name, it looks for Ids and collection, but not for EmbeddedOne or references.

I've added this to DocumentPersister::prepareQueryElement() line 1314:

        // Prepare mapped, embedded objects
        if (
            !empty($targetMapping['embedded']) && \is_object($value)
            && !$this->dm->getMetadataFactory()->isTransient($value::class)
        ) {
            return [[$fieldName, $this->pb->prepareEmbeddedDocumentValue($targetMapping, $value)]];
        }

Before:

        /* The property path may include a third field segment, excluding the
         * collection item pointer. If present, this next object property must
         * be processed recursively.
         */

It fixes the embedded issue, but not the references one.
A true fix would be a refactor of DocumentPersister::prepareQueryElement() to be recursive for embedded one mappings.